multicluster: correctly specify the dst context to clustermes connect #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct variable to specify the destination context for the clustermesh connect step, which is otherwise left empty: cilium --context gke... clustermesh connect --destination-context '' Although the workflow is currently working regardless (as the context referring to the second cluster is the default one), that no longer applies when pulling in the latest Cilium CLI changes, as --dst-context has been converted to possibly take a list of contexts. Fixes: f2fba32 ("multicluster: Run cilium-cli inside a container") Signed-off-by: Marco Iorio <[email protected]>
michi-covalent
approved these changes
Sep 23, 2024
michi-covalent
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct variable to specify the destination context for the clustermesh connect step, which is otherwise left empty:
Although the workflow is currently working regardless (as the context referring to the second cluster is the default one), that no longer applies when pulling in the latest Cilium CLI changes, as --dst-context has been converted to possibly take a list of contexts.
Fixes: f2fba32 ("multicluster: Run cilium-cli inside a container")