-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: Add gops agent #325
Merged
Merged
main: Add gops agent #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
reviewed
Jun 18, 2021
tklauser
added
the
needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Jun 29, 2021
jrajahalme
force-pushed
the
pr/jrajahalme/go-add-gops-agent
branch
from
July 19, 2021 19:51
13497ec
to
658e7f6
Compare
jrajahalme
removed
the
needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Jul 19, 2021
michi-covalent
approved these changes
Jul 19, 2021
jrajahalme
force-pushed
the
pr/jrajahalme/go-add-gops-agent
branch
from
July 19, 2021 20:28
658e7f6
to
2d63851
Compare
rolinh
approved these changes
Jul 20, 2021
Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
pr/jrajahalme/go-add-gops-agent
branch
from
August 11, 2021 11:53
2d63851
to
2da06fe
Compare
Rebased . |
tklauser
approved these changes
Aug 11, 2021
GKE test job failed on #367: https://github.com/cilium/cilium-cli/runs/3300365929?check_suite_focus=true Both are known flakes not related to this PR, merging. |
michi-covalent
added a commit
that referenced
this pull request
Sep 17, 2024
This dependency got introduced in #325 for debugging and performance improvement purposes, but my impression is that we haven't really been using it. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Sep 17, 2024
This dependency got introduced in #325 for debugging and performance improvement purposes, but my impression is that we haven't really been using it. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Sep 18, 2024
This dependency got introduced in #325 for debugging and performance improvement purposes, but my impression is that we haven't really been using it. Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the gops agent to cilium-cli so that it responds to
gops
. gops allows for stack traces and profiling, for debugging and performance improvement purposes.Signed-off-by: Jarno Rajahalme [email protected]