Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: Add gops agent #325

Merged
merged 1 commit into from
Aug 13, 2021
Merged

main: Add gops agent #325

merged 1 commit into from
Aug 13, 2021

Conversation

jrajahalme
Copy link
Member

Add the gops agent to cilium-cli so that it responds to gops. gops allows for stack traces and profiling, for debugging and performance improvement purposes.

Signed-off-by: Jarno Rajahalme [email protected]

@jrajahalme jrajahalme added the kind/feature New feature or request label Jun 15, 2021
@jrajahalme jrajahalme requested review from a team as code owners June 15, 2021 19:45
@jrajahalme jrajahalme temporarily deployed to ci June 15, 2021 19:45 Inactive
cmd/cilium/main.go Outdated Show resolved Hide resolved
@tklauser tklauser added the needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 29, 2021
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/go-add-gops-agent branch from 13497ec to 658e7f6 Compare July 19, 2021 19:51
@jrajahalme jrajahalme temporarily deployed to ci July 19, 2021 19:51 Inactive
@jrajahalme jrajahalme removed the needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 19, 2021
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/go-add-gops-agent branch from 658e7f6 to 2d63851 Compare July 19, 2021 20:28
@jrajahalme jrajahalme temporarily deployed to ci July 19, 2021 20:28 Inactive
Signed-off-by: Jarno Rajahalme <[email protected]>
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/go-add-gops-agent branch from 2d63851 to 2da06fe Compare August 11, 2021 11:53
@jrajahalme jrajahalme temporarily deployed to ci August 11, 2021 11:53 Inactive
@jrajahalme
Copy link
Member Author

Rebased .

@tklauser
Copy link
Member

GKE test job failed on #367: https://github.com/cilium/cilium-cli/runs/3300365929?check_suite_focus=true
Multicluster test job failed on #361: https://github.com/cilium/cilium-cli/runs/3300366059?check_suite_focus=true

Both are known flakes not related to this PR, merging.

@tklauser tklauser merged commit 869d9fe into master Aug 13, 2021
@tklauser tklauser deleted the pr/jrajahalme/go-add-gops-agent branch August 13, 2021 11:44
michi-covalent added a commit that referenced this pull request Sep 17, 2024
This dependency got introduced in #325 for debugging and performance
improvement purposes, but my impression is that we haven't really been
using it.

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Sep 17, 2024
This dependency got introduced in #325 for debugging and performance
improvement purposes, but my impression is that we haven't really been
using it.

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this pull request Sep 18, 2024
This dependency got introduced in #325 for debugging and performance
improvement purposes, but my impression is that we haven't really been
using it.

Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants