Update cobra to v1.2.1 and use built-in completion command #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
force-pushed
the
pr/rolinh/cobra-completion
branch
from
5afc4d5
to
9fad46d
Compare
tklauser
approved these changes
Jul 2, 2021
twpayne
approved these changes
Jul 5, 2021
tklauser
force-pushed
the
pr/rolinh/cobra-completion
branch
from
9fad46d
to
931fb09
Compare
|
Rebased to pick up #394 fixing the EKS workflows. |
This new release of cobra improves completion support. Signed-off-by: Robin Hahling <[email protected]>
Since the release of cobra v1.2.0, a completion command is automatically created if none is provided. We therefore do not need to ship our own anymore. Note that this means two breaking changes: - Calling `cilium completion` without specifying a shell name no leads to printing out the help message for the command. Our implementation used to generate completion for bash. I think that, although breaking, this change is for the better. - We used to support `ps1` as an alias for `powershell` and the builtin subcommand does not. What we get is more uniformity for our users. Most CLI tools using cobra are likely to use the built-in command to generate shell completion rather than rolling their own. Signed-off-by: Robin Hahling <[email protected]>
tklauser
force-pushed
the
pr/rolinh/cobra-completion
branch
from
931fb09
to
65b3d5e
Compare
|
Multicluster test hit #361 (https://github.com/cilium/cilium-cli/runs/2989797441?check_suite_focus=true) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the release of cobra v1.2.0, a completion command is automatically
created if none is provided. We therefore do not need to ship our own
anymore.
Note that this means two breaking changes:
cilium completionwithout specifying a shell name now leadsto printing out the help message for the command. Our implementation
used to generate completion for bash. I think that, although breaking,
this change is for the better.
subcommand does not.
What we get is more uniformity for our users. Most CLI tools using cobra
are likely to use the built-in command to generate shell completion
rather than rolling their own.