Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: remove direct dependency on github.com/golang/protobuf #393

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Jul 2, 2021

This module has been superseeded by google.golang.org/protobuf and shall not be used anymore.

@rolinh rolinh added the kind/feature New feature or request label Jul 2, 2021
@rolinh rolinh requested review from a team as code owners July 2, 2021 18:57
@rolinh rolinh requested review from ldelossa and tklauser July 2, 2021 18:57
@rolinh rolinh temporarily deployed to ci July 2, 2021 18:57 Inactive
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

This module has been superseeded by `google.golang.org/protobuf` and
shall not be used anymore.

Signed-off-by: Robin Hahling <[email protected]>
@tklauser tklauser force-pushed the pr/rolinh/remove-protobuf-ptypes branch from 7131d39 to 18ec58b Compare July 5, 2021 09:30
@tklauser tklauser temporarily deployed to ci July 5, 2021 09:30 Inactive
@tklauser
Copy link
Member

tklauser commented Jul 5, 2021

Rebased to pick up #394 to fix the EKS workflows.

@tklauser tklauser merged commit 1377be1 into master Jul 5, 2021
@tklauser tklauser deleted the pr/rolinh/remove-protobuf-ptypes branch July 5, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants