Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: verify checksum when installing latest stable CLI #438

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

tklauser
Copy link
Member

Verify the checksum of the downloaded stable CLI tarball in the
post-test information gathering stage.

Also make the curl invocation less verbose and remove ineffective
newlines from log messages while at it.

@tklauser tklauser requested review from a team as code owners July 16, 2021 13:07
@tklauser tklauser temporarily deployed to ci July 16, 2021 13:07 Inactive
.github/workflows/eks-tunnel.yaml Outdated Show resolved Hide resolved
Verify the checksum of the downloaded stable CLI tarball in the
post-test information gathering stage.

Also make the curl invocation less verbose and remove ineffective
newlines from log messages while at it.

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/verify-checksum branch from c294af4 to 513005b Compare July 19, 2021 13:49
@tklauser tklauser temporarily deployed to ci July 19, 2021 13:49 Inactive
@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 19, 2021
@nbusseneau
Copy link
Member

nbusseneau commented Jul 19, 2021

All reviews are in and EKS workflows are expected to fail with these errors following merge of #400, fix is in #442.

Since the changes are completely unrelated to EKS, we are safe to merge without rebase/retest. Marking as ready-to-merge.

@tklauser tklauser merged commit 7c336c3 into master Jul 20, 2021
@tklauser tklauser deleted the pr/tklauser/verify-checksum branch July 20, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants