Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Wait for test pods to be cleaned up #883

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented May 31, 2022

[ upstream commit b3d0e95 ]

If test pods deletion takes longer than that of (cni)
cilium pods, test pods are stuck in the "terminating"
state. This ends up failing CI jobs in the clean-up stage.
Hence, wait until test pods are deleted before moving
onto the CNI related clean-up.

[ upstream commit b3d0e95 ]

 If test pods deletion takes longer than that of (cni)
 cilium pods, test pods are stuck in the "terminating"
 state. This ends up failing CI jobs in the clean-up stage.
 Hence, wait until test pods are deleted before moving
 onto the CNI related clean-up.

Signed-off-by: Aditi Ghag <[email protected]>
Signed-off-by: Gilberto Bertin <[email protected]>
@jibi jibi requested review from tklauser and aditighag May 31, 2022 11:48
@jibi jibi requested a review from a team as a code owner May 31, 2022 11:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the backport/0.10 Backport PR for cilium-cli v0.10 label May 31, 2022
@jibi jibi temporarily deployed to ci May 31, 2022 11:48 Inactive
@jibi
Copy link
Member Author

jibi commented May 31, 2022

After this gets merged we'll need a new 0.10 release in order to fix the ci-gke-1.10 test

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser merged commit 04b4759 into v0.10 May 31, 2022
@tklauser tklauser deleted the pr/010-backport-820 branch May 31, 2022 13:03
jibi added a commit to cilium/cilium that referenced this pull request May 31, 2022
This version includes cilium/cilium-cli#883 which should fix the issue
with tests failing to complete the cleanup stage as the cilium-test
namespace can't be deleted.

Signed-off-by: Gilberto Bertin <[email protected]>
joamaki pushed a commit to cilium/cilium that referenced this pull request Jun 3, 2022
This version includes cilium/cilium-cli#883 which should fix the issue
with tests failing to complete the cleanup stage as the cilium-test
namespace can't be deleted.

Signed-off-by: Gilberto Bertin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.10 Backport PR for cilium-cli v0.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants