Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CLI tools debian quick install #367

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

clach04
Copy link
Contributor

@clach04 clach04 commented Jul 6, 2020

Command Line Tools can be used with pre-built dependencies.

Command Line Tools can be used with pre-built dependencies.
@clach04
Copy link
Contributor Author

clach04 commented Jul 6, 2020

NOTE on my SBC the Linux distro version of PIL is 4.0.0 - so if WebP support is not needed, need to disable Pillow 5 check.

I don't think that's worth documenting in the readme but mentioning for completeness. See #366

[localhost:~/kcc] # git diff
diff --git a/kindlecomicconverter/shared.py b/kindlecomicconverter/shared.py
index 507873b..1435a42 100644
--- a/kindlecomicconverter/shared.py
+++ b/kindlecomicconverter/shared.py
@@ -124,7 +124,8 @@ def dependencyCheck(level):
             missing.append('python-slugify 1.2.1+')
     try:
         from PIL import __version__ as pillowVersion
-        if StrictVersion('5.2.0') > StrictVersion(pillowVersion):
+        #if StrictVersion('5.2.0') > StrictVersion(pillowVersion):
+        if StrictVersion('4.0.0') > StrictVersion(pillowVersion):
             missing.append('Pillow 5.2.0+')
     except ImportError:
         missing.append('Pillow 5.2.0+')

clach04 referenced this pull request in whtsky/kcc Jul 6, 2020
@clach04
Copy link
Contributor Author

clach04 commented Jul 6, 2020

For more complete diff/commit to revert PIL/Pillow version check see clach04@590a93d

@darodi darodi merged commit 70de379 into ciromattia:master Jan 21, 2023
@darodi
Copy link
Collaborator

darodi commented Jan 21, 2023

@clach04
thanks
merged in v5.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants