add 7z to PATH #513
Merged
add 7z to PATH #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not at my Windows machine right now, but it was having the same failure with cbz files as well, so PATH does seem to be the issue on Windows. |
|
Added message to UI as well. Also noticed that when running from source, it uses the pre-packed 7z in the |
|
I can confirm that this fixes the issue on Windows. As you noted, the source version will prefer the 7z.exe in the 'other' folder. |
darodi
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cookie99999 @saisot2006 would this fix 7z support on Windows? I notice that when running from source it finds 7z fine but not when running the
.exeuntil added to PATH.EDIT: When running from source, it uses the 7z in the
otherfolder in the repo, not from PATH.Would prevent issues like #481 #489