Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mac damaged #572

Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix mac damaged #572

merged 1 commit into from
Aug 6, 2023

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Aug 6, 2023

If you alter the pyinstaller file with mkdir or shutil it will make the final dmg damaged. @darodi

@darodi darodi merged commit f73d889 into ciromattia:master Aug 6, 2023
@axu2
Copy link
Collaborator Author

axu2 commented Aug 6, 2023

@darodi can confirm the new DMG works.

@darodi
Copy link
Collaborator

darodi commented Aug 6, 2023

@axu2
There was a small problem during the rebase with setup.py
Thanks a lot for the recent PRs.

@axu2 axu2 deleted the damaged branch August 6, 2023 20:29
@darodi darodi modified the milestones: 5.6.4, 5.6.3 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@axu2 @darodi