Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Unsupported archive format" check #619

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Nov 17, 2023

This is a common error I've seen on various forums.

There's no point in erroring out pre-maturely. If it errors, it should error at extraction time, not when checking hardcoded conditions. I've never replicated the error myself, but I suspect that our conditions are lacking.

Since we removed the 7z/rar binaries no point anymore.

Also, can we please get a mini-release with this and the pdf fix?

@snape2019

@axu2 axu2 changed the title fix "Unsupported archive format" remove "Unsupported archive format" check Nov 18, 2023
@ronnyhammurabi
Copy link

Hey there, when I try to run this new build on Mac, I'm given the message "KCC can't be opened because Apple cannot check it for malicious software. This software needs to be updated. Contact the developer for more information."

This is after I told it to open the unverified software anyway. I haven't had this message with any of the other KCC builds, wondering if there's a fix.

Thank you for everything you do!!

@axu2
Copy link
Collaborator Author

axu2 commented Nov 19, 2023

@ronnyhammurabi right click open the app on mac. It will take a little while to open.

If it still doesn't open just extract the cbz first and use the extracted folder directly.

@ronnyhammurabi
Copy link

ronnyhammurabi commented Nov 19, 2023

@axu2 right click open method isn't working for me, build seems to not want to open at all.

I've tried your alternative method of extracting the cbz and using the extracted folder, however I still get the "unsupported archive method" when I try that. any ideas?

edit: my bad, didn't realize there was an add directory option. my bad.

@axu2 axu2 merged commit 6dcaf9a into ciromattia:master Nov 28, 2023
@axu2 axu2 deleted the archive-error branch November 28, 2023 14:54
@axu2
Copy link
Collaborator Author

axu2 commented Dec 2, 2023

@ronnyhammurabi I've fixed the opening issue, please use v5.6.4

@ronnyhammurabi
Copy link

@axu2 that worked! thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsupported archive format
2 participants