Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update detection by using requests library over urllib #649

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Dec 21, 2023

The update utility stopped working for me until i changed this.

Was getting this error

urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)>

@axu2 axu2 changed the title use requests library over urlopen fix update detection by using requests library over urllib Dec 21, 2023
@axu2 axu2 merged commit c29a4be into ciromattia:master Dec 21, 2023
@axu2 axu2 deleted the requests branch December 21, 2023 20:44
@axu2
Copy link
Collaborator Author

axu2 commented Dec 21, 2023

@catsout heads up to add requests to the flatpak.

@catsout
Copy link
Contributor

catsout commented Dec 23, 2023

@axu2 Better to add this requirement to setup.py.

@axu2
Copy link
Collaborator Author

axu2 commented Dec 23, 2023

@catsout Done

@winstonma
Copy link

winstonma commented Dec 24, 2023

@axu2 Not sure if it is related but the latest flatpak version doesn't work. Thanks for checking

$ flatpak run io.github.ciromattia.kcc
Traceback (most recent call last):
  File "/app/bin/kcc", line 33, in <module>
    sys.exit(load_entry_point('KindleComicConverter==5.6.5', 'gui_scripts', 'kcc')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/kindlecomicconverter/startup.py", line 29, in start
    from . import KCC_gui
  File "/app/lib/python3.11/site-packages/kindlecomicconverter/KCC_gui.py", line 28, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

Edit by axu2: @catsout

@catsout
Copy link
Contributor

catsout commented Dec 24, 2023

Seems with --root arg,python setup.py will not check dependencies.
I already added this requirement, wait for flathub's update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants