First commits for an Ansible role to install and configure systemd-resolved
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
force-pushed
the
first-commits
branch
2 times, most recently
from
3868f95
to
7b185bd
Compare
10 tasks
dav3r
approved these changes
May 1, 2024
mcdonnnj
reviewed
May 1, 2024
jsf9k
force-pushed
the
first-commits
branch
6 times, most recently
from
165b5b5
to
df1e703
Compare
jsf9k
force-pushed
the
first-commits
branch
4 times, most recently
from
bb8a55d
to
8314ef7
Compare
… and Jammy These platforms do not provide systemd-resolved.
Docker bind mounts a file from the host to /etc/resolv.conf. This is inconvenient for us, since we need to create a symlink at /etc/resolv.conf. At the same time, we don't want to break DNS. The playbook being imported contains a workaround for this situation.
We must start the service to populate the files in /run/systemd/resolve/, before we can create the /etc/resolv.conf.
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
/run/systemd/resolve/stub-resolv.conf is a symlink to /run/systemd/resolve/resolv.conf in AL2023, so in this case the /etc/resolv.conf symlink resolves to the former not the latter.
For some reason ansible-lint does not know about the existence of ansible.posix.mount unless ansible itself is added as an extra dependency. I believe this is because ansible is not installed when ansible-lint is installed.
The comment explains why ansible must be added as an additional dependency for the ansible-lint linter. Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Note that this entails installing dnsutils in the Molecule prepare stage so that dig is available when the Molecule tests are run.
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
mcdonnnj
approved these changes
May 8, 2024
Co-authored-by: Nick <[email protected]>
jsf9k
added a commit
to cisagov/skeleton-packer
that referenced
this pull request
May 8, 2024
…solved We can do this now that cisagov/ansible-role-systemd-resolved#1 has been approved and merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR creates an Ansible role to install and configure
systemd-resolved.💭 Motivation and context
This PR contributes to the resolution of cisagov/cool-system-internal#140 since, once this role is applied to our COOL AMIs, they will use the
systemd-resolvedstub DNS resolver.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist