Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a config drop-in instead of modifying the systemd-provided config file #7

Merged
merged 1 commit into from
May 17, 2024
Merged

Write a config drop-in instead of modifying the systemd-provided config file #7

merged 1 commit into from
May 17, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented May 16, 2024

🗣 Description

This pull request modifies the Ansible code to write a config drop-ins instead of modifying the systemd-provided config file.

💭 Motivation and context

This is the method that is preferred in the documentation.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add new or improve existing functionality labels May 16, 2024
@jsf9k jsf9k self-assigned this May 16, 2024
@jsf9k jsf9k enabled auto-merge May 16, 2024 20:59
@jsf9k jsf9k requested a review from a team May 17, 2024 02:35
dav3r
dav3r approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jsf9k jsf9k changed the title Write a config drop-ins instead of modifying the systemd-provided config file Write a config drop-in instead of modifying the systemd-provided config file May 17, 2024
@jsf9k jsf9k merged commit 923f21c into develop May 17, 2024
15 checks passed
@jsf9k jsf9k deleted the improvement/use-drop-in branch May 17, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add new or improve existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10