Lineage pull request for: skeleton #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rules to enforce ATX-closed headers, dashes for unordered list elements, and `1.` for ordered list elements.
Add <h1> and <img> tags to the allowed list for MD033 (HTML elements) to support using an image as the first thing in a markdown file (header image).
This converts the existing `.mdl_config.json` file to an equivalent `.mdl_config.yaml` file. The reference in the markdownlint pre-commit hook configuration is updated to match. Co-authored-by: Shane Frasier <[email protected]>
Now that this is a YAML file we can add comments explaining the rule modifications we use. This will make it easier to edit or expand in the future.
This hook will validate any pre-commit hook manifest files in the repository.
We should be doing this because the Packer and Terraform pre-commit hooks leverage the corresponding executables; therefore, it makes sense to go ahead and install the particular versions of those executables that we support. Also add support for optionally debugging via tmate. See also cisagov/skeleton-generic#74.
Co-authored-by: Nick M. <[email protected]>
There is no reason to create /usr/bin/terraform. This is a vestige of an earlier age. Co-authored-by: Nick M. <[email protected]>
The Terraform installation does not destroy the existing system Terraform installation, and neither should the Packer installation. Co-authored-by: Nick M. <[email protected]>
Note that this change is dependent on the merging of cisagov/setup-env-github-action#31. Co-authored-by: Nick M. <[email protected]>
Some variables defined in the go installation are used in the cache task, so the go installation must happen first. Co-authored-by: Nick M. <[email protected]>
Co-authored-by: Nick M. <[email protected]>
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation. Co-authored-by: Nick M. <[email protected]>
The `shfmt` tool does not ship on the GitHub Actions runners so we must install it manually.
We have had a difficult time with how beautysh parses some shellscripts. I went in pursuit of an alternative and I believe shfmt to be a good alternative. Co-authored-by: Shane Frasier <[email protected]>
This is performed by running `pre-commit autoupdate`, but with the `ansible-lint` hook held back manually.
Update pre-commit Hooks
Add the validate_manifest Hook to pre-commit Configuration
Update markdownlint Configuration
…-for-linting Install terraform and packer for the linting job
…_shfmt Replace beautysh hook with cisagov/pre-commit-shfmt
cisagovbot
added
the
upstream update
jsf9k
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-generic.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage