Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the docker-compose.override.yml file #36

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Remove the docker-compose.override.yml file #36

merged 1 commit into from
Dec 8, 2022

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Dec 8, 2022

🗣 Description

This pull request removes the docker-compose.override.yml file from the repository.

💭 Motivation and context

Previously cisagov/ansible-role-code-gov-update relied on pulling down the Docker Compose configuration from this repository. The docker-compose.override.yml file was necessary to provide the specific configuration that we use for this Docker image. However as of cisagov/ansible-role-code-gov-update#31 the appropriate configuration is stored in cisagov/ansible-role-code-gov-update instead. Thus we no longer need to keep any deployment specific configuration in this repository.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Remove the docker-compose.override.yml file
cf7f0de 
Now that this deployment specific override file has been integrated
into cisagov/ansible-role-code-gov-update in
cisagov/ansible-role-code-gov-update#31 we no longer need to store it
in this project.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 8, 2022
@mcdonnnj mcdonnnj requested a review from jsf9k as a code owner December 8, 2022 16:08
@mcdonnnj mcdonnnj self-assigned this Dec 8, 2022
@mcdonnnj mcdonnnj requested a review from dav3r December 8, 2022 16:08
dav3r
dav3r approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit 3870d76 into improvement/modernize_project Dec 8, 2022
@mcdonnnj mcdonnnj deleted the improvement/remove_docker-compose_override_file branch December 8, 2022 19:44
@mcdonnnj mcdonnnj mentioned this pull request Mar 17, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r