Use cisagov/scraper instead of llnl-scraper from PyPI
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fork includes changes that we need but are not present in the upstream project at this time. The version specification for the llnl-scraper package is updated in the Pipfile and the configuration is re-locked to update the lockfile.
Bump from 0.38.4 to 0.40.0.
mcdonnnj
added
improvement
jsf9k
approved these changes
Mar 16, 2023
dav3r
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request changes the source of the llnl-scraper package from PyPI to our fork. As part of that we re-lock the pipenv configuration. We also bump the version of wheel installed into the Python virtual environment in the Docker image to the latest release.
@dav3r is added as a CODEOWNER so that future pull requests should have at least two non-creator CODEOWNERS to pull in for review.
💭 Motivation and context
There are some fixes and changes needed for this configuration to successfully run. While waiting for them to (hopefully) be integrated into the official package we can use our fork in the interim to get the functionality we need.
🧪 Testing
Automated testing passes. I was able to successfully use this configuration both locally and testing in our AWS deployment where this is used in production with no issues.
✅ Pre-approval checklist