Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create report exporting functionality from the dashboard #964 #1063

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Create report exporting functionality from the dashboard #964 #1063

merged 4 commits into from
Apr 27, 2021

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Apr 5, 2021 •
edited
Loading

fixes #964

  • first step of report generation
  • design of pdf and placement of button are open for changes

Screen Shot 2021-04-05 at 3 46 57 PM

Screen Shot 2021-04-05 at 3 45 51 PM

@epicfaace
Copy link
Member

Thanks! Can you add screenshots both of 1) the button and 2) the generated PDF file?

@aloftus23
Copy link
Contributor Author

I am also investigating why npm run build is failing in the frontend tests.

@epicfaace
Copy link
Member

Related issue: parallax/jsPDF#2846

@epicfaace
Copy link
Member

Can you use the uswds button component so the button looks better?

@aloftus23
Copy link
Contributor Author

Screen Shot 2021-04-05 at 4 49 32 PM

@epicfaace
Copy link
Member

Looks good. @aloftus23 can you make sure that the graphs on the PDFs aren't cut off as well?

@epicfaace epicfaace merged commit 9946d6c into master Apr 27, 2021
@epicfaace epicfaace deleted the frontendReport branch April 27, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace approved these changes

Assignees

@aloftus23 aloftus23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create basic report exporting functionality from the dashboard
2 participants
@aloftus23 @epicfaace