-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2725: member management page - [NL] #2837
Conversation
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
1 similar comment
🥳 Successfully deployed to developer sandbox nl. |
@@ -666,6 +667,194 @@ def test_organization_members_waffle_flag_on_shows_nav_link(self): | |||
self.assertContains(home, "Hotel California") | |||
self.assertContains(home, "Members") | |||
|
|||
@less_console_noise_decorator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing test_views_members_json (see similar test files)
Mostly nitpicks but overall great work @CocoByte! |
Co-authored-by: Rachid Mrad <[email protected]>
🥳 Successfully deployed to developer sandbox nl. |
Thank you @zandercymatics and @rachidatecs for the thorough review and polishing :) |
…anage.get.gov into nl/2725-member-management-page
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
@rachidatecs / @CocoByte Adding those missing unit tests. Kept it simple for now. I also fixed a few bugs with the search, sort, etc |
🥳 Successfully deployed to developer sandbox nl. |
1 similar comment
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
from django_webtest import WebTest # type: ignore | ||
|
||
|
||
class GetPortfolioMembersJsonTest(TestWithUser, WebTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a teardown class and cleanup the data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a teardown class for the new test class
Ticket 2725
Resolves #2725
Change
Context for reviewers
Setup
Code is deployed on sandbox-nl
Since we don't have fixtures for this yet, you will need to setup a portfolio, assign a few domains to it, and give users portfolio permissions.
To do this, navigate to /admin and do the following (NOTE: if the database has not been reset, these are likely already done.);
Code Review Verification Steps
---- BEGIN ----
After completing setup, navigate to /domains and verify...
Navigate to /members (in the url) and verify the following (NOTE: you might wish to open a separate tab to change permissions in order to test these scenarios)...
One final AC to check:
In /admin, verify that...
---- DONE ----
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots