-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963
base: main
Are you sure you want to change the base?
Conversation
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
… hotgov/2852-property-to-portfolio-related-fields
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
@@ -173,7 +173,7 @@ <h2 class="text-primary-darker"> Summary of your domain request </h2> | |||
{% endwith %} | |||
{% endif %} | |||
|
|||
{% if DomainRequest.organization_name %} | |||
{% if DomainRequest.converted_organization_name %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asaki222 isn't this on the request form? Or am I reading this wrong? For your ticket the idea is that you will only change the ones for django admin, not every domain request form peice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abroddrick I didn't get a chance to comb through it(this is a rough draft), and clean it up yet. I was just focusing on getting a general working solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abroddrick Removed!
🥳 Successfully deployed to developer sandbox hotgov. |
1 similar comment
🥳 Successfully deployed to developer sandbox hotgov. |
🥳 Successfully deployed to developer sandbox hotgov. |
Ticket
Resolves #00
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots