[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963

asaki222 · 2024-10-21T13:36:13Z

Ticket

Resolves #00

Changes

Change 1
Change 2

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

github-actions · 2024-10-21T13:41:08Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-21T13:51:26Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-21T22:24:28Z

🥳 Successfully deployed to developer sandbox hotgov.

… hotgov/2852-property-to-portfolio-related-fields

github-actions · 2024-10-22T00:03:28Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-22T14:16:59Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-22T20:32:30Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-22T21:08:41Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-23T16:55:03Z

🥳 Successfully deployed to developer sandbox hotgov.

abroddrick · 2024-10-23T23:47:57Z

src/registrar/templates/includes/domain_request_status_manage.html

@@ -173,7 +173,7 @@ <h2 class="text-primary-darker"> Summary of your domain request </h2>
            {% endwith %}
        {% endif %}

-        {% if DomainRequest.organization_name %}
+        {% if DomainRequest.converted_organization_name %}


@asaki222 isn't this on the request form? Or am I reading this wrong? For your ticket the idea is that you will only change the ones for django admin, not every domain request form peice.

@abroddrick I didn't get a chance to comb through it(this is a rough draft), and clean it up yet. I was just focusing on getting a general working solution.

@abroddrick Removed!

github-actions · 2024-10-24T00:39:30Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-24T00:43:17Z

🥳 Successfully deployed to developer sandbox hotgov.

github-actions · 2024-10-24T01:02:37Z

🥳 Successfully deployed to developer sandbox hotgov.

asaki222 added 2 commits October 18, 2024 12:33

currrent thing

436809f

changes so far

6599515

asaki222 requested a review from abroddrick as a code owner October 21, 2024 13:36

ran the formatteR

db0806b

asaki222 added 2 commits October 21, 2024 11:54

added additional methods to the html template that I missed

32183a2

added missing parts of the converted methods

e69a296

abroddrick added the Review Priority🥇 label Oct 21, 2024

Merge branch 'main' of https://github.com/cisagov/manage.get.gov into…

5e8612b

… hotgov/2852-property-to-portfolio-related-fields

more changes

271eb01

updated the addressline1

bfded58

asaki222 added 2 commits October 22, 2024 16:45

ran the formatter

00d0208

reverted changes due to changing ac

dec877b

fixed one test

015a08b

abroddrick reviewed Oct 23, 2024

View reviewed changes

asaki222 added 2 commits October 23, 2024 20:34

welcome

bac8d67

removed print statements

37ebe4e

updated the tests

eb2a5f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963

[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963

asaki222 commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

abroddrick Oct 23, 2024

asaki222 Oct 24, 2024

asaki222 Oct 24, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024

[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963

Are you sure you want to change the base?

[DRAFT] #2852 property to portfolio related fields - [HOTGOV] #2963

Conversation

asaki222 commented Oct 21, 2024

Ticket

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

abroddrick Oct 23, 2024

Choose a reason for hiding this comment

asaki222 Oct 24, 2024

Choose a reason for hiding this comment

asaki222 Oct 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024