Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust files supported by the hooks #36

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Adjust files supported by the hooks #36

merged 3 commits into from
Sep 10, 2024

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request adjusts the files supported by the hooks defined in this repository.

💭 Motivation and context

At this point there is no sense in continuing to support packer.json files as the HCL2 configuration language has been preferred since Packer 1.7. We should also be formatting any .pkrvars.hcl files just like we would otherwise format .tfvars files in a Terraform configuration.

🧪 Testing

Automated tests pass. I verified that the expected files are picked up with these patterns.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Adjust hook file patterns
8427f07 
Drop `packer.json` for the `packer_validate` hook and add Packer
variable files (`.pkrvars.hcl`) to the `packer_fmt` hook.
@mcdonnnj
Drop always_run from the packer_validate hook
56b5587 
This should not be needed.
@mcdonnnj
Update the README
1420947 
Remove the blurb about `packer_validate` now that it no longer checks
`packer.json` paths and adding files as additional arguments is just
pre-commit behavior.
@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Sep 10, 2024
@mcdonnnj mcdonnnj requested a review from a team September 10, 2024 20:53
@mcdonnnj mcdonnnj self-assigned this Sep 10, 2024
dav3r
dav3r approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit e44282f into develop Sep 10, 2024
4 checks passed
@mcdonnnj mcdonnnj deleted the improvement/adjust_supported_files branch September 10, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jsf9k jsf9k Awaiting requested review from jsf9k jsf9k is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @dav3r @dv4harr10