Use directories instead of individual files for the packer_validate
hook
#38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the
packer_validate
hook to process unique directories instead of individual files. It also removes thepass_filenames
option from the hook configurations for both thepacker_fmt
and thepacker_validate
hooks.💭 Motivation and context
This change will allow us to support multiple
*.pkr.hcl
files for a configuration instead of having to cram everything into a single file to ensure it passes thepacker_validate
hook. This change is also necessary to support converting the Packer configurations in cisagov/cyhy_amis to use HCL2 instead of the legacy JSON format.The
pass_filesnames
option is removed from both hooks because it is setting the option to the default value.🧪 Testing
Automated tests pass. I tested this version of the hook against cisagov/skeleton-packer after decomposing the
packer.pkr.hcl
file.Note
The local versions run below have some debug output present just for verification.
I also converted the Packer configurations in cisagov/cyhy_amis to HCL2 and used the local versions to verify the configuration:
✅ Pre-approval checklist