Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Version Management Tooling #6

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Add Version Management Tooling #6

merged 1 commit into from
Jul 13, 2021

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jul 6, 2021

🗣 Description

This PR adds the version management tooling I put in cisagov/pre-commit-shfmt.

💭 Motivation and context

This keeps a versioning record in the commit history as well as providing the tooling to update and tag in a scripted manner to ensure consistency.

🧪 Testing

This is the same tooling we use on most of our projects. I have also used it successfully in cisagov/pre-commit-shfmt.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Add version number management
28be41e 
Add the version number management that was implemented in
cisagov/pre-commit-shfmt to this repo. This will provide version management and
ease of tagging for this project. The version is set to the latest tag in the
repository.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 6, 2021
@mcdonnnj mcdonnnj self-assigned this Jul 6, 2021
dav3r
dav3r approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎵 Like a version, bumped for the very first time... 🎵

@mcdonnnj mcdonnnj merged commit a04ce9a into develop Jul 13, 2021
@mcdonnnj mcdonnnj deleted the improvement/add_versioning_helpers branch July 13, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r