Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Entry - Remove Treasury #58

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Duplicate Entry - Remove Treasury #58

merged 1 commit into from
Oct 21, 2022

Conversation

cfx47
Copy link
Contributor

@cfx47 cfx47 commented Oct 12, 2022

Remove duplicate for Department of the Treasury. Agency is already listed in CSV with correct ID (TREAS)

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Add a tag or create a release.

Remove duplicate for Department of the Treasury. Agency is already listed in CSV with correct ID (TREAS)
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ‘
Further evidence why we like to keep things sorted alphabetically - this would have (hopefully) been noticed earlier.

@dav3r
Copy link
Member

dav3r commented Oct 12, 2022

PS: In the future, please fill out all of the sections in our pull request template.

@dav3r dav3r requested a review from jsf9k October 21, 2022 15:50
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Oct 21, 2022
@jsf9k jsf9k merged commit 8b7c549 into cisagov:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants