Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update four Federal agency names in agencies.csv #87

Merged
merged 2 commits into from
May 30, 2024

Conversation

cfx47
Copy link
Contributor

@cfx47 cfx47 commented May 30, 2024

🗣 Description

Update four Federal agency names to match the agency names shown in the list of domains being pulled in other repos.

💭 Motivation and context

Names do not match with domain repositories, so these federal agencies are not receiving their BOD 18-01 reports (HTTPS and Trustymail).

🧪 Testing

No testing was completed for this, as the changes should then send agencies their BOD 18-01 reports, as names will match.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Update 4 Federal agency names to match the names of domains being pulled in other repos.
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍
I confirmed that the following reports were generated last week, but not mailed out:

cyhy-Export-Import Bank of the United States-2024-05-25-https-report.pdf
cyhy-Export-Import Bank of the United States-2024-05-25-tmail-report.pdf
cyhy-Japan-U.S. Friendship Commission-2024-05-25-https-report.pdf
cyhy-Japan-U.S. Friendship Commission-2024-05-25-tmail-report.pdf
cyhy-Peace Corps-2024-05-25-https-report.pdf
cyhy-Peace Corps-2024-05-25-tmail-report.pdf
cyhy-U.S. Chemical Safety Board-2024-05-25-https-report.pdf
cyhy-U.S. Chemical Safety Board-2024-05-25-tmail-report.pdf

The changes in this PR should enable reports for these entities to be sent out after this change has been deployed.

I also confirmed that each of these four entities exist in the CyHy DB and all have "BOD" in their report_types list.

@dav3r
Copy link
Member

dav3r commented May 30, 2024

@cfx47 - Please go through each item in the "Pre-approval checklist" above and check all boxes that apply and delete any checkboxes that do not apply to this PR. Thanks!

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 30, 2024
@mcdonnnj mcdonnnj changed the title Update 4 Federal names in agencies.csv Update four Federal agency names in agencies.csv May 30, 2024
@dav3r dav3r requested a review from a team May 30, 2024 19:55
@jsf9k jsf9k unassigned dav3r and mcdonnnj May 30, 2024
@jsf9k jsf9k enabled auto-merge May 30, 2024 20:02
@jsf9k jsf9k merged commit 4f8c1f9 into cisagov:develop May 30, 2024
9 checks passed
jsf9k added a commit to cisagov/orchestrator that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants