Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust to env #67

Closed
wants to merge 1 commit into from
Closed

Add Rust to env #67

wants to merge 1 commit into from

Conversation

jasonodoom
Copy link
Contributor

🗣 Description

This PR adds Rust to our env so it can be consumed/used in GitHub Actions workflows. Specifically, dtolnay/rust-toolchain

💭 Motivation and context

This change is based on current team practices.

🧪 Testing

Pre-commit verified syntactical accuracy.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@dav3r
Copy link
Member

dav3r commented Aug 29, 2023

Can you please give us more context about why Rust is needed? Do we have some pending work or PR that will utilize it? This info should be included in the "Motivation and context" section above.

Comment on lines +36 to +37
- id: setup-rust
uses: dtolnay/rust-toolchain@stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the repo it's very dead. The last release was in 2020.

@jsf9k
Copy link
Member

jsf9k commented Aug 29, 2023

Can you please give us more context about why Rust is needed? Do we have some pending work or PR that will utilize it? This info should be included in the "Motivation and context" section above.

I took @mcdonnnj's comment and the successful linting action in cisagov/skeleton-generic#143 to indicate that this is unnecessary.

@mcdonnnj
Copy link
Member

Can you please give us more context about why Rust is needed? Do we have some pending work or PR that will utilize it? This info should be included in the "Motivation and context" section above.

I took @mcdonnnj's comment and the successful linting action in cisagov/skeleton-generic#143 to indicate that this is unnecessary.

Adding on to this per the runner image software list the Rust tool-chain should already be available.

@jasonodoom
Copy link
Contributor Author

Can you please give us more context about why Rust is needed? Do we have some pending work or PR that will utilize it? This info should be included in the "Motivation and context" section above.

I took @mcdonnnj's comment and the successful linting action in cisagov/skeleton-generic#143 to indicate that this is unnecessary.

Adding on to this per the runner image software list the Rust tool-chain should already be available.

@jsf9k @mcdonnnj Aah, I didn't know this. In that case, closing.

@jasonodoom jasonodoom closed this Aug 29, 2023
@jsf9k jsf9k deleted the add-rust branch August 29, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants