-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust to env #67
Add Rust to env #67
Conversation
Can you please give us more context about why Rust is needed? Do we have some pending work or PR that will utilize it? This info should be included in the "Motivation and context" section above. |
- id: setup-rust | ||
uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the more official GH Action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the repo it's very dead. The last release was in 2020.
I took @mcdonnnj's comment and the successful linting action in cisagov/skeleton-generic#143 to indicate that this is unnecessary. |
Adding on to this per the runner image software list the Rust tool-chain should already be available. |
@jsf9k @mcdonnnj Aah, I didn't know this. In that case, closing. |
🗣 Description
This PR adds Rust to our env so it can be consumed/used in GitHub Actions workflows. Specifically, dtolnay/rust-toolchain
💭 Motivation and context
This change is based on current team practices.
🧪 Testing
Pre-commit verified syntactical accuracy.
✅ Pre-approval checklist