Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the Python and Go versions we use for general GitHub Actions jobs #70

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 13, 2023

🗣 Description

This adds appropriate outputs to track the versions of Python and Go that should serve as "defaults" for use in our GitHub Actions workflows.

💭 Motivation and context

It's somewhat cumbersome to keep updating all the different versions hard-coded in workflows. It would make sense to reference the outputs of this Action unless specifically undesired.

🧪 Testing

Automated tests pass. This change is used in cisagov/skeleton-generic#157 to switch over to this change for our skeleton projects.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code labels Nov 13, 2023
@mcdonnnj mcdonnnj self-assigned this Nov 13, 2023
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking 👍

@mcdonnnj mcdonnnj merged commit 77fe1d0 into develop Nov 13, 2023
5 checks passed
@mcdonnnj mcdonnnj deleted the improvement/add_python_and_go_versions branch November 13, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants