Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependabot ignore directive for molecule #197

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jun 6, 2024

🗣 Description

This pull request adds a commented out dependabot ignore directive for the molecule package.

💭 Motivation and context

Since we specify a pin for the molecule package we should defensively add a dependabot ignore directive. That way if we were to add an upper bound at some point any downstream repositories are already correctly configured to let this project manage the dependency.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Since we have a version pin of some kind for the molecule package in
the `requirements-test.txt` file it makes sense to ensure this
dependency is centrally managed.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file labels Jun 6, 2024
@mcdonnnj mcdonnnj self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

3 participants