Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lower-bound pin for pytest-testinfra #201

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 25, 2024

🗣 Description

This pull request adds a lower-bound pin for pytest-testinfra.

💭 Motivation and context

We do this because pytest-testinfra 10.1.1 contains a fix for SystemdService.exists that is required by some roles' Molecule test code.

Note that we also add a corresponding line to the Dependabot configuration so that descendant repos know this dependency is managed here.

🧪 Testing

All automated tests pass. See also cisagov/ansible-role-systemd-resolved#8.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

We do this because pytest-testinfra 10.1.1 contains a fix for
SystemdService.exists that is required by some roles' Molecule test
code.

Note that we also add a corresponding line to the Dependabot
configuration so that descendant repos know this dependency is managed
here.

Co-authored-by: Nick <[email protected]>
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file labels Jun 25, 2024
@jsf9k jsf9k self-assigned this Jun 25, 2024
@jsf9k jsf9k marked this pull request as ready for review June 25, 2024 15:46
@jsf9k jsf9k requested a review from a team June 25, 2024 15:46
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: In Progress
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

4 participants