Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same version of Bandit throughout the pre-commit config file #30

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use the same version of Bandit throughout the pre-commit config file #30

wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Aug 28, 2024 •
edited
Loading

🗣 Description

This pull request updates the pre-commit configuration file to use the same version of the Python package bandit throughout.

💭 Motivation and context

It doesn't make sense to run Bandit twice with different versions.

🧪 Testing

All automated tests pass. I also verified that my Emacs code to install dependencies from pre-commit now functions as expected; previously, it was failing because two different versions of the bandit package were being requested.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Aug 28, 2024
@jsf9k jsf9k force-pushed the bugfix/use-same-version-of-bandit branch from 2b72d10 to 4fa7aed Compare August 28, 2024 13:30
@jsf9k
Use the same version of Bandit throughout the pre-commit config file
c8f9da0 
It doesn't make sense to run Bandit twice with different versions.
@jsf9k jsf9k force-pushed the bugfix/use-same-version-of-bandit branch from 4fa7aed to c8f9da0 Compare August 28, 2024 13:32
@jsf9k jsf9k marked this pull request as ready for review August 28, 2024 13:38
@jsf9k jsf9k requested a review from a team August 28, 2024 13:38
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Aug 28, 2024
dav3r
dav3r approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @dv4harr10 @mcdonnnj