Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Docker warnings #31

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Get rid of Docker warnings #31

wants to merge 2 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 3, 2024 •
edited
Loading

🗣 Description

This pull request gets rid of one warning from docker compose and two warnings from docker build.

💭 Motivation and context

  • The docker-compose warning is due to the fact that the version key has been deprecated in Docker composition files.
  • The docker warnings are both due to the fact that in Dockerfile the word AS should be uppercase in FROM...AS... lines.

Code without warnings is cleaner code.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Remove deprecated version key from Docker composition file
450adf5 
This gets rid of a warning from docker-compose.
@jsf9k
Capitalize "AS" in FROM lines
8df9437 
This gets rid of a warning from Docker.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Sep 3, 2024
@jsf9k jsf9k self-assigned this Sep 3, 2024
@jsf9k jsf9k marked this pull request as ready for review September 3, 2024 13:21
@jsf9k jsf9k requested a review from a team September 3, 2024 13:21
dav3r
dav3r approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

lwersiy
lwersiy approved these changes Sep 3, 2024
View reviewed changes
Copy link

@lwersiy lwersiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsf9k jsf9k mentioned this pull request Oct 1, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@lwersiy lwersiy lwersiy approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsf9k @dav3r @dv4harr10 @lwersiy @mcdonnnj