Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to version 3.12 of Python #154

Closed
wants to merge 1 commit into from
Closed

Upgrade to version 3.12 of Python #154

wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 25, 2023 •
edited
Loading

🗣 Description

This pull request upgrades GitHub Actions to use the latest minor version of Python.

💭 Motivation and context

The latest version Python is likely more efficient than previous versions.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release github-actions Pull requests that update GitHub Actions code labels Oct 25, 2023
@jsf9k jsf9k marked this pull request as ready for review October 25, 2023 17:25
@jsf9k jsf9k requested a review from a team October 25, 2023 17:25
jsf9k added a commit to cisagov/skeleton-docker that referenced this pull request Oct 25, 2023
@jsf9k
Update workflow to use Python version 3.12
4967e8d 
Note that this instance _will not_ be updated via the upstream pull
request cisagov/skeleton-generic#154.
@jsf9k jsf9k mentioned this pull request Oct 25, 2023
Open
6 tasks
jsf9k added a commit to cisagov/skeleton-python-library that referenced this pull request Oct 25, 2023
@jsf9k
Add support for Python version 3.12 in build workflow
29d7d1c 
Note that these instances _will not_ be updated via the upstream pull
request cisagov/skeleton-generic#154.
@jsf9k jsf9k mentioned this pull request Oct 25, 2023
Merged
6 tasks
@mcdonnnj mcdonnnj mentioned this pull request Nov 13, 2023
Merged
7 tasks
@mcdonnnj
Copy link
Member

mcdonnnj commented Mar 5, 2024

@jsf9k Are you alright with me closing this PR out in favor of #157?

@jsf9k
Copy link
Member Author

jsf9k commented Mar 5, 2024

@jsf9k Are you alright with me closing this PR out in favor of #157?

OK 😢

@mcdonnnj
Copy link
Member

mcdonnnj commented Mar 5, 2024

This pull request has been superseded by #157 but thank you to @jsf9k for giving me the idea for a long-term solution!

@mcdonnnj mcdonnnj closed this Mar 5, 2024
@mcdonnnj mcdonnnj deleted the improvement/upgrade-python-version branch March 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @mcdonnnj @dav3r @dv4harr10