Install terraform and packer for the linting job #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
blocked
We should be doing this because the Packer and Terraform pre-commit hooks leverage the corresponding executables; therefore, it makes sense to go ahead and install the particular versions of those executables that we support. Also add support for optionally debugging via tmate. See also #74.
jsf9k
force-pushed
the
improvement/install-tf-and-packer-for-linting
branch
from
da12b0a
to
106af21
Compare
mcdonnnj
requested changes
Jul 9, 2021
Co-authored-by: Nick M. <[email protected]>
There is no reason to create /usr/bin/terraform. This is a vestige of an earlier age. Co-authored-by: Nick M. <[email protected]>
The Terraform installation does not destroy the existing system Terraform installation, and neither should the Packer installation. Co-authored-by: Nick M. <[email protected]>
7 tasks
Note that this change is dependent on the merging of cisagov/setup-env-github-action#31. Co-authored-by: Nick M. <[email protected]>
mcdonnnj
requested changes
Jul 11, 2021
Some variables defined in the go installation are used in the cache task, so the go installation must happen first. Co-authored-by: Nick M. <[email protected]>
mcdonnnj
approved these changes
Jul 12, 2021
Co-authored-by: Nick M. <[email protected]>
8 tasks
jsf9k
added a commit
to cisagov/skeleton-packer
that referenced
this pull request
Jul 13, 2021
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
jsf9k
added a commit
to cisagov/skeleton-packer
that referenced
this pull request
Jul 13, 2021
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
jsf9k
added a commit
to cisagov/skeleton-packer
that referenced
this pull request
Jul 13, 2021
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
mcdonnnj
requested changes
Jul 13, 2021
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation. Co-authored-by: Nick M. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the tasks for the
lintjob to install the versions of Terraform and Packer that we support.Please note that this pull request requires that cisagov/setup-env-github-action#31 be merged first.
💭 Motivation and context
As described in #74, the Packer and Terraform
pre-commithooks leverage the corresponding executables; therefore, it makes sense to go ahead and install the particular versions of those executables that we support.Resolves #74.
🧪 Testing
All
pre-commithooks and GitHub Actions pass.✅ Checklist