-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install terraform and packer for the linting job #82
Install terraform and packer for the linting job #82
Conversation
We should be doing this because the Packer and Terraform pre-commit hooks leverage the corresponding executables; therefore, it makes sense to go ahead and install the particular versions of those executables that we support. Also add support for optionally debugging via tmate. See also #74.
da12b0a
to
106af21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of implementing this improvement! I have some suggestions and also some items I would like consensus on before approving.
Co-authored-by: Nick M. <[email protected]>
There is no reason to create /usr/bin/terraform. This is a vestige of an earlier age. Co-authored-by: Nick M. <[email protected]>
The Terraform installation does not destroy the existing system Terraform installation, and neither should the Packer installation. Co-authored-by: Nick M. <[email protected]>
Note that this change is dependent on the merging of cisagov/setup-env-github-action#31. Co-authored-by: Nick M. <[email protected]>
Some variables defined in the go installation are used in the cache task, so the go installation must happen first. Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some consistency suggestions. Thanks for your work on implementing this 🏆
Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy baby, yeah! 🇬🇧
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated change from reading Go documentation/release notes for something else I'm working on.
As of [Go 1.16](https://tip.golang.org/doc/go1.16#go-command) the `GO111MODULE` environment variable defaults to `on` and `go get` has been deprecated for module installation. Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣 Description
This pull request modifies the tasks for the
lint
job to install the versions of Terraform and Packer that we support.Please note that this pull request requires that cisagov/setup-env-github-action#31 be merged first.
💭 Motivation and context
As described in #74, the Packer and Terraform
pre-commit
hooks leverage the corresponding executables; therefore, it makes sense to go ahead and install the particular versions of those executables that we support.Resolves #74.
🧪 Testing
All
pre-commit
hooks and GitHub Actions pass.✅ Checklist