Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the --non-interactive flag when installing type stubs via mypy #138

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 24, 2024

🗣 Description

This pull reques

  • Adds the --non-interactive flag when installing type stubs via mypy
  • Moves the mypy command toward the end of the setup-env script

💭 Motivation and context

  • This flag forces mypy to hide the errors about missing stubs and instead simply install stubs without asking for confirmation. It also does not return an error code, which it does without this flag even if you opt to let it install the missing type stubs.
  • Moving the mypy command toward the end of the setup-env script ensures that, should the command fail, all the other good stuff in the script will still happen.

🧪 Testing

All automated tests pass. These changes were tested as part of cisagov/cyhy-config#5.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

This flag forces mypy to hide the errors about missing stubs and
instead simply install stubs without asking for confirmation.  It also
does not return an error code, which it does without this flag even if
you opt to let it install the missing type stubs.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Sep 24, 2024
@jsf9k jsf9k self-assigned this Sep 24, 2024
@jsf9k jsf9k marked this pull request as ready for review September 24, 2024 17:59
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Sep 24, 2024
@jsf9k jsf9k requested a review from a team September 24, 2024 18:54
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with this change. 👍

This allows all the other good things to happen even if the mypy
command fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: In Progress
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

4 participants