-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linking against BoringSSL #349
Conversation
Latest commit updates to current
The CMake magic for telling the build system to link BoringSSL is still not great, but other than that, I think this is approaching a plausible state. We should add a CI job for it before merging. |
Is a merge for this one imminent? We're integrating mlspp and currently leveraging the boring branch for BoringSSL support but would like to get back to main. |
@birarda - To be honest, some help here would be welcome. I think the code changes are pretty much done, and just need some review. The main outstanding tasks are (1) updating the CMake build structure to be more elegant, (2) adding a CI job that builds against BoringSSL (in parallel with OpenSSL 1.1 / 3.0). And maybe (3) adding a section to the README about how to select which of the three libraries to use to use. |
Would be happy to assist here. I’m guessing you’ll need to do (2)? Could you provide any further guidance on what you’d like for (1), if necessary outside of what is described in the PR description? I can PR to this branch for (1) and (3). |
I think you should be able to do (2) just by making changes in the For (1) -- If you look at the CMakeLists in this PR, it is hard-coded to always use BoringSSL, and always find it in |
add info to readme for BoringSSL/OpenSSL undo spacing changes prepare for vcpkg enabled boringssl add test workflow for boringssl remove the cmake module path remove an extra newline fix a typo remove an extra newline
Replaced by #376 |
This is a very drafty draft PR looking at the possibility of enabling linkage against BoringSSL as well as OpenSSL. I have included only the changes required to the CMake files to find the appropriate parts of BoringSSL (and even then, manually pointed to my local install). To get this merged, we would need to:
OPENSSL_*
variable assignments)hpke
module to accommodate API differences, as in Updated to support OpenSSL 3 #295