Provide more flexible JWK parsing #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glhewett
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Looks good to me. I have one comment that requires review.
I also see in this PR and in other places the comparison of json string to provide equality between to objects (Credential or Keys). The way that we are using the objects, I don't think there is an issue, but there is the case that attributes from a json string can change order and break the equality erroneously. It might not be a real case, but I want to note it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JWK import requires the caller to specify the cipher suite for the key. This is not always known. This PR introduces a
PublicJWKclass that provides more fulsome JWK parsing, including capturing thealgandkidparameters.