Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error in Visual Studio 17.7 #372

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix build error in Visual Studio 17.7 #372

merged 2 commits into from
Sep 18, 2023

Conversation

czlitony
Copy link
Contributor

@czlitony czlitony commented Sep 16, 2023 •
edited
Loading

Fix build error on Windows:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2664	'std::optional<mls_v4::Node> &std::optional<mls_v4::Node>::operator =(std::optional<mls_v4::Node> &&)': cannot convert argument 1 from 'initializer list' to 'std::optional<mls_v4::Node> &&'	mlspp_v4	J:\dev\webex\spark-client-framework\thirdparty\mlspp_v4\src\treekem.cpp	495	
Error	C2664	'std::optional<mls_v4::GroupSecrets::PathSecret> &std::optional<mls_v4::GroupSecrets::PathSecret>::operator =(std::optional<mls_v4::GroupSecrets::PathSecret> &&)': cannot convert argument 1 from 'initializer list' to 'std::optional<mls_v4::GroupSecrets::PathSecret> &&'	mlspp_v4	J:\dev\webex\spark-client-framework\thirdparty\mlspp_v4\src\messages.cpp	163

How to reproduce the build error?

  1. Use Visual Studio 2022 v17.7 (I reproduced with vs2022 v17.7.4)
  2. Use c++20

@bifurcation bifurcation merged commit 8a010ef into cisco:main Sep 18, 2023
10 checks passed
glhewett pushed a commit that referenced this pull request Oct 19, 2023
@czlitony @glhewett
Fix build error in Visual Studio 17.7 (#372)
4a24bd0 
* Fix build error in Visual Studio 17.7

* fix format issue

---------

Co-authored-by: chengzhl <[email protected]>
Co-authored-by: liangxil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bifurcation bifurcation bifurcation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czlitony @bifurcation