Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl dependency cleanup #426

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

RichLogan
Copy link
Contributor

  • Move OpenSSL dependency directly to libhpke definition.
  • Replace add_compile_definitions with target_compile_definitions to ensure proper propagation of defines.
  • Added a test to ensure the custom WITH_BORINGSSL define gets set when compiling with BoringSSL - maybe overkill but helped me validate this change so might be useful. I had to set a property on test discovery to make ctest not see skips as failures. Ref: CTest (using catch_discover_tests) treats skipped tests as failed catchorg/Catch2#2873

Although this is a standalone change the motivation here was to do some pre-work for looking into #425

@bifurcation bifurcation merged commit 7d94b14 into cisco:main Oct 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants