Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libhpke
definition.add_compile_definitions
withtarget_compile_definitions
to ensure proper propagation of defines.WITH_BORINGSSL
define gets set when compiling with BoringSSL - maybe overkill but helped me validate this change so might be useful. I had to set a property on test discovery to make ctest not see skips as failures. Ref: CTest (using catch_discover_tests) treats skipped tests as failed catchorg/Catch2#2873Although this is a standalone change the motivation here was to do some pre-work for looking into #425