Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic ci #732

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Add basic ci #732

merged 2 commits into from
Jul 29, 2019

Conversation

boundless-forest
Copy link
Contributor

@boundless-forest boundless-forest commented Jul 29, 2019

Add basic ci

Now, we just retain some basic check scripts, list as following:

  • fmt
  • security audit
  • clippy
  • release

Temporarily ignore security audit. I came cross a error because of memoffset's bug.

ID:	 RUSTSEC-2019-0011
Crate:	 memoffset
Version: 0.2.1
Date:	 2019-07-16
URL:	 https://github.com/Gilnaa/memoffset/issues/9#issuecomment-505461490
Title:	 Flaw in offset_of and span_of causes SIGILL, drops uninitialized memory of arbitrary type on panic in client code
Solution: upgrade to: >= 0.5.0

Fix steps:

  1. update cita_logger's dependence of cross-beam
  2. update all crate relevant with crossbeam in cita-common, include pubsub*, engine, tokio-core
  3. update cita using new cita-common

Reference

Memoffset bug Info
Cross-beam issue
Tokio issue

@leeyr338 leeyr338 merged commit 2e9da3b into citahub:remove-gpl Jul 29, 2019
@boundless-forest boundless-forest deleted the add_ci branch July 29, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants