Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format codes and Add Travis CI. #1

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Conversation

yangby-cryptape
Copy link
Contributor

I did not change any rust codes, manually, just format them, and add Travis CI.

Since I want to add some methods in next PR, add CI first.

Cargo.lock Outdated
@@ -0,0 +1,182 @@
[[package]]
name = "bit-vec"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ignore cargo.lock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo wll not be updated frequently after development.
So, I think Cargo.lock is helpful to keep a available dependency tree.
If there is no Cargo.lock, maybe two month later, it can not be compiled successfully.

Keep or remove, both are ok, IMHO.
I will remove the commit "Add Cargo.lock file.", after rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@u2 u2 merged commit 1a81774 into citahub:master Aug 6, 2018
@yangby-cryptape yangby-cryptape deleted the develop branch August 6, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants