Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options for data sent to UI #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dalrae1
Copy link

@Dalrae1 Dalrae1 commented Sep 17, 2022

This will allow screenshot_basic:requestScreenshot to actually work correctly. The original code would not receive the options, and would cause the server export "requestClientScreenshot" to not send any requests back to the server when fileName is nil. Since the readme states that an undefined fileName should return a data uri this is the incorrect behavior

This will allow screenshot_basic:requestScreenshot to actually work correctly. 
The original code would not receive the options, and would cause the server export "requestClientScreenshot" to not send any requests back to the server when fileName is nil. 
Since the readme states that an undefined fileName should return a data uri this is the incorrect behavior
@MDGamesmaster
Copy link

dont know where to put this but fresh install and getiing this error

[ 42672] [b2699_GTAProce] MainThrd/ Dropping duplicate player for netID 1 (slotID 128).
[ 42672] [b2699_GTAProce] MainThrd/ ^2[AUTH] logged in as 'MD.GamesMaster' with perms: ["all_permissions"]
[ 42672] [b2699_GTAProce] MainThrd/ React loaded, sending variables.
[ 42672] [b2699_GTAProce] MainThrd/ ^2ServerCtx updated from global state
[ 42875] [b2699_GTAProce] MainThrd/ Returning device Headset Earphone (CORSAIR VOID ELITE Wireless Gaming Dongle) for GUID {3AED98B8-9AD8-4977-BF1E-C697AFF2D098}
[ 42954] [b2699_GTAProce] [Mumble] Audio Input/ Returning device Headset Microphone (CORSAIR VOID ELITE Wireless Gaming Dongle) for GUID {D9BBFCB0-379F-459D-9B63-3F01BE2C1EA1}
[ 42954] [b2699_GTAProce] [Mumble] Audio Input/ MumbleAudioInput::InitializeAudioDevice: Initialized audio capture device.
[ 43079] [b2699_GTAProce] MainThrd/ Connecting to mumble, setting targets.
[ 43344] [b2699_GTAProce] MainThrd/ Script initialization finished.
[ 43360] [b2699_GTAProce] CrBrowserMain/ THREE.WebGLRenderer 101dev (@screenshot-basic/dist/ui.html:15)
[ 43438] [b2699_GTAProce] CrBrowserMain/ f? (@screenshot-basic/dist/ui.html:15)
[ 43610] [b2699_GTAProce] MainThrd/ Finished connection logic
[ 43750] [b2699_GTAProce] CrBrowserMain/ Uncaught TypeError: Cannot read properties of null (reading 'focus') (@game/ui/root.html:108)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants