fix(bot): handling of disallowed intents

Discord.js throws an unhandlable rejection when the bot does not have a
required privileged intent.
This hacky changes listens to the unhandledRejection and tries to handle
it gracefully.

Related issue:
discordjs/discord.js#9621

core/components/DiscordBot/index.ts

@@ -54,19 +54,29 @@ export default class DiscordBot {
     guild: Discord.Guild | undefined;
     guildName: string | undefined;
     announceChannel: Discord.TextBasedChannel | undefined;
+    lastDisallowedIntentsError: number = 0;
 
 
     constructor(txAdmin: TxAdmin, public config: DiscordBotConfigType) {
         this.#txAdmin = txAdmin;
 
         if (this.config.enabled) {
-            this.startBot().catch();
+            this.startBot().catch((e) => {});
         }
 
+        // FIXME: Hacky solution to fix the issue with disallowed intents
+        // Remove this when issue below is fixed 
+        // https://github.com/discordjs/discord.js/issues/9621
+        process.on('unhandledRejection', (error: Error) => {
+            if (error.message === 'Used disallowed intents') {
+                this.lastDisallowedIntentsError = Date.now();
+            }
+        });
+
         //Cron
         setInterval(() => {
             if (this.config.enabled) {
-                this.updateStatus().catch();
+                this.updateStatus().catch((e) => {});
             }
         }, 60_000)
     }
@@ -219,8 +229,22 @@ export default class DiscordBot {
             //Setting up client object
             this.#client = new Client(this.#clientOptions);
 
+            //Setup disallowed intents unhandled rejection watcher
+            const lastKnownDisallowedIntentsError = this.lastDisallowedIntentsError;
+            const disallowedIntentsWatcherId = setInterval(() => {
+                if (this.lastDisallowedIntentsError !== lastKnownDisallowedIntentsError) {
+                    clearInterval(disallowedIntentsWatcherId);
+                    return sendError(
+                        `This bot does not have a required privileged intent.`,
+                        { code: 'DisallowedIntents' }
+                    );
+                }
+            }, 250);
+
+
             //Setup Ready listener
             this.#client.on('ready', async () => {
+                clearInterval(disallowedIntentsWatcherId);
                 if (!this.#client?.isReady() || !this.#client.user) throw new Error(`ready event while not being ready`);
 
                 //Fetching guild
@@ -283,31 +307,33 @@ export default class DiscordBot {
                     }
                 }
 
-            
+
                 // if previously registered by tx before v6 or other bot
                 this.guild.commands.set(slashCommands).catch(console.error);
                 this.#client.application?.commands.set([]).catch(console.error);
 
-                this.updateStatus().catch();
+                this.updateStatus().catch((e) => {});
 
                 console.ok(`Started and logged in as '${this.#client.user.tag}'`);
                 return resolve();
             });
 
             //Setup remaining event listeners
             this.#client.on('error', (error) => {
+                clearInterval(disallowedIntentsWatcherId);
                 console.error(`Error from Discord.js client: ${error.message}`);
                 return reject(error);
             });
             this.#client.on('resume', () => {
                 console.verbose.ok('Connection with Discord API server resumed');
-                this.updateStatus().catch();
+                this.updateStatus().catch((e) => {});
             });
             this.#client.on('interactionCreate', interactionCreateHandler.bind(null, this.#txAdmin));
             // this.#client.on('debug', console.verbose.debug);
 
             //Start bot
             this.#client.login(this.config.token).catch((error) => {
+                clearInterval(disallowedIntentsWatcherId);
                 console.error(`Discord login failed with error: ${(error as Error).message}`);
                 return reject(error);
             });

core/index.ts

@@ -53,6 +53,9 @@ process.stderr.on('error', (data) => { });
 
 //Handle "the unexpected"
 process.on('unhandledRejection', (err: Error) => {
+    //We are handling this inside the DiscordBot component
+    if(err.message === 'Used disallowed intents') return;
+
     console.error('Ohh nooooo - unhandledRejection');
     console.dir(err);
 });

docs/dev_notes.md

@@ -1,5 +1,6 @@
 # TODO:
 - [x] improve timeout handling of discord bot save
+- [x] fix handling of disallowed intents
 - [ ] attempt to update mysql2 and got
 - [ ] improve the bot with dangerous permissions message
 - [ ] merge PRs