Dropdown DatePicker Receive Query #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that these components will automatically update when the inputs change instead of requiring a query to manually set them
|
We used to have a Receive Query for both, and got rid of them. We got rid of the DatePicker's in #66 for performance reasons. We also added one in this commit, but got rid of it later, I think in these two commits. But you can read the discussion around why we can't have a Receiver for renderless components in #79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds a
Receivequery to the dropdown and date picker components.How should this be manually tested?
Setting the input of these controls to some externally controlled state -- the components display values should update when the external state changes
Other Notes
I opted to just using H.put to update the state. These components have their state set entirely by input so this shouldn't break anything, but let me know if I'm off base on something here.