Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizers):add case insensitive filtering for organizers #21

Merged

Conversation

beefysalad
Copy link
Member

@beefysalad beefysalad commented Sep 6, 2022

Description

Add case-insensitive filtering for organizers name upon creation

Checklist

  • Reviewed own code
  • Commented on code that is hard to understand
  • Implemented tests for the feature/bugfix
  • All GitHub status checks pass
  • The frontend and backend PR previews have been deployed

Backend only

  • Added test data for new entity
  • Generated the client api if there are new or deleted endpoints and/or DTOs

@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pnrn-pnrn ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 5:38AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
pnrn-pnrn-staging ⬜️ Ignored (Inspect) Sep 6, 2022 at 5:38AM (UTC)

@beefysalad beefysalad force-pushed the feature/add-case-insensitive-filtering-for-organizers branch from a6556cd to 72d250c Compare September 6, 2022 05:37
@princhcanal princhcanal temporarily deployed to pnrn-pnrn-pr-21 September 6, 2022 05:37 Inactive
});
return OrganizerService.convertToDTO(newOrganizer);
if (result.length > 0) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used if else here to check if the result variable will return an array containing the data that matches the query if none, it will proceed with the creation of organizer.

@beefysalad beefysalad marked this pull request as ready for review September 6, 2022 05:43
@beefysalad beefysalad requested a review from a team as a code owner September 6, 2022 05:43
@beefysalad beefysalad merged commit 8e59bb3 into dev Sep 6, 2022
@beefysalad beefysalad deleted the feature/add-case-insensitive-filtering-for-organizers branch September 6, 2022 05:59
Copy link
Member

@princhcanal princhcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants