Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project name): PNRN-30 change project name #3

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

princhcanal
Copy link
Member

@princhcanal princhcanal commented Aug 31, 2022

Description

  • change project name in package.json

Checklist

First, create a draft pull request. Then mark the PR as ready for review when all necessary checkbox items has been completed

  • Reviewed own code
  • Commented on code that is hard to understand
  • Implemented tests for the feature/bugfix
  • All GitHub status checks pass
  • The frontend and backend PR previews have been deployed

Backend only

  • Generated the client api if there are new or deleted endpoints and/or DTOs

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pnrn-pnrn ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 1:15PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
pnrn-pnrn-staging ⬜️ Ignored (Inspect) Aug 31, 2022 at 1:15PM (UTC)

@@ -1,5 +1,5 @@
{
"name": "frontend",
"name": "teknoy-ems-frontend",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is changing the name on the frontend

@princhcanal princhcanal marked this pull request as ready for review August 31, 2022 13:07
@princhcanal princhcanal requested a review from a team as a code owner August 31, 2022 13:07
Copy link
Member

@beefysalad beefysalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noice-noise
noice-noise previously approved these changes Aug 31, 2022
Copy link
Contributor

@noice-noise noice-noise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Tis good ser.

Copy link
Member

@beefysalad beefysalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm i think you can do better

Copy link
Contributor

@noice-noise noice-noise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ayus!

@princhcanal princhcanal merged commit c79294b into dev Aug 31, 2022
@princhcanal princhcanal deleted the chore/PNRN-30-change-project-name branch August 31, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants