Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Navigation Link clean up #101

Closed
ifsimicoded opened this issue Jan 17, 2018 · 1 comment
Closed

Navigation Link clean up #101

ifsimicoded opened this issue Jan 17, 2018 · 1 comment
Labels
effort: medium

Comments

@ifsimicoded
Copy link
Contributor

ifsimicoded commented Jan 17, 2018 •
edited
Loading

Found NavLink Router components (already part of React-router4+) that could clean up a lot of the logic in our components for rendering "active" states for links.

Also found basename attribute in the Browser Router component that could clean up a lot more of the logic that we use to build urls for Links.

@mateoclarke ^^
@ifsimicoded ifsimicoded mentioned this issue Jan 17, 2018
Closed
@ifsimicoded
Copy link
Contributor Author

Closing as this was addressed via PR #163 and with an entirely new nav in #171

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benweatherman @ifsimicoded