This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Navigation cleanup #102
Closed
Navigation cleanup #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoclarke
reviewed
Jan 17, 2018
There was a problem hiding this comment.
I ❤️ this code and I think it does the right thing, simplifying our logic around active state.
But, I'm worried about how this would work in a static world. Until we have more clarity about how we port our site into Next, Gatsby, etc, we might not want to lean into NavLink or other components provided by react-router-dom.
For example, Next uses its own routing library which doesn't seem to have NavLink in their API: https://github.com/zeit/next.js#routing
Gatsby's Link component actually has a wrapper component that acts as a plugin for react-router-dom.
https://www.npmjs.com/package/gatsby-link
mateoclarke
pushed a commit
that referenced
this pull request
Jan 23, 2018
Active state styling wasn't being applied in the Navmenu because of language code prefixed in the paths. Doing this made me think that the NavLink component provided by react-router-dom is a better solution than this. ex: #102 🙃 We should use existing router functionality once we choose a router for server-side/static generation.
|
Waiting to determine which routing library we stick with for static rendering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
implemented NavLinks component to simplify active class logic.