fix: Reconsider CLI defaults #392 #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue-392, I have implemented the following fixes:
Set the default node size to g4s.kube.xsmall
Set the default number of nodes to 2
Ensured firewall rules are correctly applied during cluster creation
However, I was unable to make the OS selection deterministic. The API documentation does not seem to provide any guidance on this. Could you please advise on how to achieve this?
Screenshots:
Please review and let me know if any further changes are needed.
@haardikdharma10 @RealHarshThakur @uzaxirr @fernando-villalba