Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix support #2

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Helix support #2

merged 2 commits into from
Mar 13, 2023

Conversation

rome-user
Copy link
Contributor

As promised, here is the PR that adds support for Helix.

@cjohansen
Copy link
Owner

Great stuff! Seeing as there is nothing helix-specific in here, the namespace might as well be portfolio.react. Keeping the helix example is fine.

Could you also add a note in the relevant section of the Readme, so people know it's available? 😊

Just like the rest of the samples, this provides a small, non-trivial
example of how to define a scene.
@rome-user
Copy link
Contributor Author

OK I have renamed portfolio.helix to portfolio.react and updated the sample to reflect this.

@cjohansen cjohansen merged commit 6241ad7 into cjohansen:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants