Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for blue status bar height when shrinking keyboard #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ccorcos
Copy link
Contributor

@ccorcos ccorcos commented Jul 14, 2017

When you open up your app with a the blue navigation status bar, something (not sure what) offsets the view by the additional size of the larger statusbar (image 1).

However, when I open up the keyboard, the function that accounts for the shrinked view doesnt account for this offset (2) and when you close the keyboard, this issue remains (3).

However, with my fix, it all works (4) :)

(1)
img_1731

(2)
img_1733

(3)
img_1734

(4)
img_1732

@cjpearson
Copy link
Owner

Thanks for the bug report and fix! I'll take a look at it. Does this occur just with google maps or do phone calls cause the same issue?

@ccorcos
Copy link
Contributor Author

ccorcos commented Jul 17, 2017

Yup. Same with phone calls. Also fixes the issue I reported here: #53

@ccorcos
Copy link
Contributor Author

ccorcos commented Aug 22, 2017

@cjpearson also fixes #55

@cjpearson
Copy link
Owner

cjpearson commented Sep 18, 2017

@ccorcos, sorry for the late response. I finally got a chance to test this out. I was using the iPhone 6s sim on 9.3 with the the statusbar plugin also installed. Although it also seems to occur without the statusbar plugin.

I found an issue with the first fix. When StatusBarOverlaysWebView=false and KeyboardShrinksView=true, the view gets smaller each time you open the keyboard leaving a large white space at the top of the screen.

image

(Ignore the button text. ShrinkView is in fact true in this test.)

@ccorcos
Copy link
Contributor Author

ccorcos commented Sep 19, 2017

Ah, I'm using StatusBarOverlaysWebView=true so I havent been able to test that.

@ccorcos
Copy link
Contributor Author

ccorcos commented Dec 7, 2017

@cjpearson have you looked into this?

@cjpearson
Copy link
Owner

@ccorcos, sorry for the late reply I've been away. I only pulled in part of the fix since it broke when StatusBarOverlaysWebView=false and I haven't looked at what it would take to fix that. I had assumed it was a lower priority since you had a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants