-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Alpine with a Python (3.10) base image for CKAN 2.10 and master branches #61
Conversation
@EricSoroos - if you get a chance would you please be able to take a look at this? |
@@ -0,0 +1,62 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file have any difference with the current start_ckan.sh? If not I think it would be great to avoid duplication, we have a lot of it already in this repo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amercader - Iv'e updated filenames, image names...got consistent with using |
No need to reference a python specific details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wardi can you share the approach you mentioned to autoactivate the venv when running a command in the container? cheers
Yes we can use https://docs.docker.com/reference/dockerfile/#entrypoint to run commands before other |
Co-authored-by: Adrià Mercader <[email protected]>
Co-authored-by: Adrià Mercader <[email protected]>
Co-authored-by: Adrià Mercader <[email protected]>
@amercader - I have committed your suggested change to rename the Dockerfile (for python) to remove the "dash" - Just confirming that this is what you want as I will need to update a few more things - thanks |
Co-authored-by: Adrià Mercader <[email protected]>
@kowh-ai yes, this way is consistent with the tag ending in |
@kowh-ai can you bring the new Dockerfile based on I can't imagine that this issue hasn't been solved somehow on the official Python images |
@amercader - I was unsuccessful is recreating the pip issue using the python/bookworm base image. I'm really not sure why...anyway Iv'e made changes (commented out any |
Fixes: #54
The objective is to upgrade from the alpine 2.17 base image to an official DockerHub Python 3.10 base image. We opted for a Debian 12 (bookworm slim) base image.
No alterations have been made to the current CKAN 2.9 builds.
Efforts were made to streamline the system libraries to only include essential components.
Upon successful testing and integration of this PR, several improvements will be realized:
I'm happy to take suggestions for better naming of files and images